livedata: show Nernst voltage #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mck1117
reviewed
May 29, 2023
| @@ -15,6 +15,7 @@ | |||
| struct measure_results { | |||
| float nernstAc; | |||
| float nernstDc; | |||
| float nernstV; | |||
There was a problem hiding this comment.
why do we have nernstAc, nernstDc, and nernstV?
There was a problem hiding this comment.
To log only what we interested in.
There was a problem hiding this comment.
????
why do we have all three of these channels? what is the value of logging the newly added nernstV?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.